Add SDK Manager and updated CUDA install options #547
+43
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
bdice
requested changes
Oct 8, 2024
Comment on lines
+29
to
32
| - [SDK Manager](#wsl2-sdkm) | ||
| - [Conda](#wsl2-conda) | ||
| - [Docker](#wsl2-docker) | ||
| - [pip](#wsl2-pip) |
There was a problem hiding this comment.
Can we move this below pip? I think we should keep the order "Conda, Docker, pip, SDK Manager" to match the above.
Suggested change
| - [SDK Manager](#wsl2-sdkm) | |
| - [Conda](#wsl2-conda) | |
| - [Docker](#wsl2-docker) | |
| - [pip](#wsl2-pip) | |
| - [Conda](#wsl2-conda) | |
| - [Docker](#wsl2-docker) | |
| - [pip](#wsl2-pip) | |
| - [SDK Manager](#wsl2-sdkm) |
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
bdice
requested changes
Oct 9, 2024
There was a problem hiding this comment.
There are still a few open conversations from my last review pass. Please take a look at those before requesting a re-review.
https://github.com/rapidsai/docs/pull/547/files#r1792563333
https://github.com/rapidsai/docs/pull/547/files#r1792564184
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
Co-authored-by: Bradley Dice <[email protected]>
bdice
reviewed
Oct 9, 2024
install/index.md
Outdated
| 1. In Windows, install or update WSL2 [using Microsoft's instructions](https://docs.microsoft.com/en-us/windows/wsl/install){: target="_blank"}. | ||
| 2. Install the [latest NVIDIA Drivers](https://www.nvidia.com/download/index.aspx){: target="_blank"} on the Windows host. | ||
| 3. Download [SDK Manager's Ubuntu version from their website](https://developer.nvidia.com/sdk-manager){: target="_blank"} (requires sign up or login to NVIDIA's Developer community). Do not install yet. It is assumed that your home directory's `Downloads` folder is where the `.deb` file will be stored. If not, please move `sdkmanager_[version]-[build#]_amd64.deb` file to your current Download folder. | ||
| 4. Open PowerShell command line or Windows terminal, run: |
There was a problem hiding this comment.
We should already have WSL installed from following the instructions linked in Step 1. Please remove this step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are adding: